Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-2044 - Can't archive an observation variable that is in use #391

Merged
merged 7 commits into from
Aug 15, 2024

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Aug 1, 2024

Description

Story: BI-2044

  • Added isDisabled prop to src/components/forms/BasicInputField.vue
    • Not used in this card was going to but decided on different approach, left in for possible future use
  • Added editable and editableCheckLoading props to BaseTraitForm to facilitate hiding controls there
  • Updated edit update logic to separate changing active status from updating trait, it was already using the /archive endpoint so just kept changes on the front end

NOTE: Seeing an issue testing this and on qa-test as well when switching between the Active and Archived tabs on the ontology page, the pages are blank and some api calls are not being made unless you do a hard refresh. Created a new bug card for this: https://breedinginsight.atlassian.net/browse/BI-2271?atlOrigin=eyJpIjoiYzc5OGVhMjJiMDVkNGJjNWFmNjZjYjI3MjA3ZDEwZTciLCJwIjoiaiJ9

Dependencies

Please include any dependencies to other code branches, testing configurations, scripts to be run, etc.

Testing

  • Test different combinations of archiving and restoring for traits that have experiment data collected on them and traits that don't.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@nickpalladino nickpalladino changed the title BI-2044 BI-2044 - Can't archive an observation variable that is in use Aug 1, 2024
@nickpalladino nickpalladino marked this pull request as ready for review August 9, 2024 15:38
@nickpalladino nickpalladino requested review from a team, davedrp and HMS17 and removed request for a team August 9, 2024 15:40
@davedrp davedrp self-assigned this Aug 12, 2024
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed test

@nickpalladino nickpalladino merged commit a26b705 into develop Aug 15, 2024
1 check passed
@nickpalladino nickpalladino deleted the feature/BI-2044 branch August 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants