BI-2259 - Disable Sub-entity Dataset option Mange experiments menu #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedrp
requested review from
a team,
dmeidlin and
nickpalladino
and removed request for
a team
nickpalladino
approved these changes
Jul 29, 2024
| @@ -152,7 +152,7 @@ export default class ExperimentDetails extends ProgramsBase { | |||
| private actions: ActionMenuItem[] = [ | |||
| new ActionMenuItem('experiment-import-file', 'import-file', 'Import file'), | |||
| new ActionMenuItem('experiment-download-file', 'download-file', 'Download file'), | |||
| new ActionMenuItem('experiment-create-sub-entity-dataset', 'create-sub-entity-dataset', 'Create Sub-Entity Dataset') | |||
| // new ActionMenuItem('experiment-create-sub-entity-dataset', 'create-sub-entity-dataset', 'Create Sub-Entity Dataset') | |||
There was a problem hiding this comment.
Since we're planning to re-enable this shortly after the MVP I think this is ok. Probably still technically possible to hit the api and create a sub-entity dataset if someone really wanted to but I'm not worried about it.
dmeidlin
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2259 - Disable Sub-entity Dataset option Mange experiments menu
Commented out the menu option for 'Create Sub-Entity Dataset'. (it is assumed that it will be un-commented later)
Dependencies
bi-api: develop branch
Testing
(see also the Acceptance Criteria on BI-2259.)
EXPECTED RESULT
you should no longer see the Create Sub-Entity Dataset optin
Checklist: