Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-1975 - "Unknown" Breeding Method not recognized #387

Merged
merged 1 commit into from
Jul 2, 2024
Merged

BI-1975 - "Unknown" Breeding Method not recognized #387

merged 1 commit into from
Jul 2, 2024

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jun 26, 2024 •
edited by jira bot
Loading

Description

Story: BI-1975

  • Updated link to germplasm import template

Dependencies

Testing

  • Germplasm import accepts UNK and Unknown breeding methods for germplasm records
  • Breeding methods in program administration page shows Increase for the UNK method class

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Jun 26, 2024
@nickpalladino nickpalladino requested review from mlm483, dmeidlin and HMS17 and removed request for dmeidlin June 26, 2024 21:00
@mlm483 mlm483 self-assigned this Jul 1, 2024
mlm483
mlm483 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@nickpalladino nickpalladino merged commit 5d75494 into develop Jul 2, 2024
2 checks passed
@nickpalladino nickpalladino deleted the bug/BI-1975 branch July 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlm483 mlm483 mlm483 approved these changes

@HMS17 HMS17 HMS17 approved these changes

Assignees

@mlm483 mlm483

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickpalladino @HMS17 @mlm483