[BI-2102] Accessibility: Make Color Contrast Meet AA Standard #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedrp
requested review from
a team,
dmeidlin and
mlm483
and removed request for
a team
dmeidlin
approved these changes
Jun 7, 2024
mlm483
requested changes
Jun 25, 2024
src/assets/scss/main.scss
Outdated
| $turquoise: #3FB3B6; | ||
| $dark-turquoise: #297577; | ||
| //$dark-turquoise: #2d8082; |
There was a problem hiding this comment.
Please remove or document why this commented-out line is here.
src/assets/scss/main.scss.bak
Outdated
| @@ -0,0 +1,1037 @@ | |||
| /*! | |||
There was a problem hiding this comment.
I don't think this file should be in git. If we really need to find the old values, we can look at the commit history.
dmeidlin
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2102 Accessibility: Make Color Contrast Meet AA Standard
Dependencies
bi-api: develop branch
Testing
NOTE: To test this install the Siteimprove Accessibility Checker browser plugin found at https://chromewebstore.google.com/detail/siteimprove-accessibility/djcglbmbegflehmbfleechkjhmedcopn?pli=1
Go to BrAPI Information page.
EXPECTED RESULT
The Siteimprove Accessibility Checker should not report the issue
Color contrast does not meet minimum requirementGo to the Jobs page.
EXPECTED RESULT
The Siteimprove Accessibility Checker should not report the issue
Color contrast does not meet minimum requirementGo to any page that includes a buefy table with pagination (for example, the Gemplasm page).
EXPECTED RESULT
The Siteimprove Accessibility Checker should not report the issue
Color contrast does not meet minimum requirementChecklist: