BI-2121 - Workflows Select #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlm483
approved these changes
May 16, 2024
Comment on lines
+50
to
+56
| static async getWorkflowsForMapping(mappingId: string | undefined) : Promise<BiResponse> { | ||
| const { data } = await api.call({ | ||
| url: `${process.env.VUE_APP_BI_API_V1_PATH}/import/mappings/${mappingId}/workflows`, | ||
| method: 'get' | ||
| }) as Response; | ||
| return new BiResponse(data); | ||
| } |
There was a problem hiding this comment.
Can one mapping have many workflows associated with it?
There was a problem hiding this comment.
Ya, the experiment import mapping has three workflows associated with it
Comment on lines
+110
to
+115
| static async updateUploadData(programId: string, mappingId: string, uploadId: string, workflowId: string | undefined, userInput: any, commit: boolean) { | ||
| let url = `${process.env.VUE_APP_BI_API_V1_PATH}/programs/${programId}/import/mappings/${mappingId}/data/${uploadId}`; | ||
|
|
||
| if (workflowId !== undefined) { | ||
| url = `${process.env.VUE_APP_BI_API_V1_PATH}/programs/${programId}/import/mappings/${mappingId}/workflows/${workflowId}/data/${uploadId}`; | ||
| } |
There was a problem hiding this comment.
I think it makes sense that only one workflow can be interacted with at once. Unless there is a plan to chain multiple workflows into pipelines? Probably wouldn't make sense to make that transparent to the user.
There was a problem hiding this comment.
Ya, I think a single workflow at this level makes sense. Maybe for the updating of datasets there could internally be different workflows for sub obs unit vs exp unit that are conditionally kicked off by the general append / update workflow.
dmeidlin
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2121
Dependencies
Testing
Checklist: