Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-2059 - Field Book not displaying nominal categories from DeltaBreed #371

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Apr 2, 2024

Description

Story: BI-2059

  • Changed default Field Book BrAPI category settings from Label to Value

Dependencies

  • bi-api release/0.9
  • Field Book

Testing

  • Scan QR code for BrAPI settings in Delta Breed and verify that the category option is set to Value in Field Book
  • Verify that both nominal and ordinal traits have values displayed on buttons on collect screen in Field Book

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@nickpalladino nickpalladino changed the title Bug/bi 2059 BI-2059 Apr 2, 2024
@nickpalladino nickpalladino changed the title BI-2059 BI-2059 - Field Book not displaying nominal categories from DeltaBreed Apr 2, 2024
@nickpalladino nickpalladino requested review from a team, dmeidlin and mlm483 and removed request for a team April 2, 2024 18:17
Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running FB v5.6.13 in Android Studio and get this error
BI-2059ScanErr
when I scan this QR code
FBScanTestBI-2059
. The Value category appears in the Deltabreed UI.

Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming Dave's issue is resolved.

@nickpalladino
Copy link
Member Author

I'm running FB v5.6.13 in Android Studio and get this error BI-2059ScanErr when I scan this QR code FBScanTestBI-2059 . The Value category appears in the Deltabreed UI.

@dmeidlin if you scan a QR code on rel-test does it work or do you get a similar error?

@dmeidlin
Copy link
Contributor

dmeidlin commented Apr 5, 2024

When I try scanning the QR code for the Field-Book demo program on rel-test, I get a different error.
relTEstFBSyncErr
@nickpalladino What version of FB are you using?

@nickpalladino nickpalladino changed the base branch from develop to release/0.9 April 5, 2024 17:56
@nickpalladino nickpalladino merged commit e17a18b into release/0.9 Apr 5, 2024
@nickpalladino nickpalladino deleted the bug/BI-2059 branch April 5, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants