BI-2029 (Experiment Preview and Visual Progress Indicators Broken in v0.90 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bounds error in cellClassIfExisting()
davedrp
requested review from
a team,
dmeidlin and
nickpalladino
and removed request for
a team
|
Can you make sure this gets merged into the release/0.9 branch as well develop |
nickpalladino
approved these changes
Jan 9, 2024
dmeidlin
approved these changes
Jan 11, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2029 Experiment Preview and Visual Progress Indicators Broken in v0.9
In ImportExperiment.vue,the method createObservationIndexMap() was setting values in this.observationIndexMap that cause an out-of-bounds error in cellClassIfExisting. This modifies createObservationIndexMap() so that does not happen.
Dependencies
bi-api: development branch
Testing
EXPECTED RESULT
Experiment preview is displayed.
Checklist: