Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-2005 - Expand Exp Template #355

Merged
merged 7 commits into from
Jan 8, 2024
Merged

BI-2005 - Expand Exp Template #355

merged 7 commits into from
Jan 8, 2024

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Dec 12, 2023 •
edited
Loading

Description

Story: BI-2005

  • created a new experiment template file and updated box link
  • Added geocoordinate columns to experiment preview and view tables

Dependencies

Testing

  • Ensure that validations as specified in card work

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino
Copy link
Member Author

I'm kicking off a taf run. Guessing some experiment files will need to be updated

davedrp
davedrp approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed developer testing

@nickpalladino nickpalladino merged commit 1926385 into develop Jan 8, 2024
1 check passed
@nickpalladino nickpalladino deleted the feature/BI-2005 branch January 8, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlm483 mlm483 mlm483 approved these changes

@davedrp davedrp davedrp approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickpalladino @davedrp @mlm483