Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-1935 - Error remains displayed #347

Merged
merged 1 commit into from
Nov 7, 2023
Merged

BI-1935 - Error remains displayed #347

merged 1 commit into from
Nov 7, 2023

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Nov 6, 2023 •
edited
Loading

Description

Story: BI-1935

  • Clear notifications like import template does

Dependencies

  • None

Testing

  • Verify that error notification is cleared when new file is uploaded after an existing error

bi_ontology_template_v14_good.xlsx
bi_ontology_template_v14_error.xlsx

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@nickpalladino nickpalladino requested review from a team, davedrp and dmeidlin and removed request for a team November 6, 2023 17:50
@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2023
@davedrp davedrp self-assigned this Nov 7, 2023
@davedrp
Copy link
Contributor

davedrp commented Nov 7, 2023

passed developer test

@nickpalladino nickpalladino merged commit aa59494 into develop Nov 7, 2023
1 check passed
@nickpalladino nickpalladino deleted the bug/BI-1935 branch November 7, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@davedrp davedrp davedrp approved these changes

Assignees

@davedrp davedrp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickpalladino @davedrp @dmeidlin