Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-1921 - Support Field Book Study Import from DeltaBreed #346

Merged
merged 11 commits into from
Jan 25, 2024

Conversation

timparsons
Copy link
Member

@timparsons timparsons commented Nov 6, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1921

Please include a summary of the change that was made.

Dependencies

  • bi-api/feature/BI-1921
  • Latest version of FieldBook main branch

Testing

Field Book QR Code BrAPI Config

  1. In DeltaBreed, navigate to a program
  2. Navigate to the BrAPI menu
  3. Ensure the "Field Book" tab is selected
  4. In Field Book, navigate to the BrAPI settings screen
  5. Tap the "Auto Configure" button, and choose to scan a configuration
  6. Scan the QR code displayed on DeltaBreed
  7. Ensure that the DeltaBreed config successfully imports into Field Book and that Field Book starts the process of authenticating against DeltaBreed

Importing into Field Book
Pre-req: must already have set up the BrAPI connection to DeltaBreed

  1. In DeltaBreed, load an experiment with an environment, observation units, and traits (does not matter if there is data collected for the traits or not)
  2. In Field Book, navigate to the import field via BrAPI screen
  3. Ensure that there are only environments from the program you are logged in to (should see environments from a different program)
  4. Choose an environment, and tap "Preview Field"
  5. Ensure the preview loads successfully with the correct number of plots and traits
  6. Tap "Save", and ensure the field is successfully saved
  7. Ensure you can collect data for the field
  8. Export the collected data to a flat file
  9. Modify the export file to be in the DeltaBreed experiment import format
  10. Upload the data file to DeltaBreed
  11. Ensure the observations are properly stored

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/7062065819

@timparsons timparsons force-pushed the feature/BI-1921 branch 2 times, most recently from a969289 to 655b60f Compare November 30, 2023 21:13
@timparsons timparsons marked this pull request as ready for review November 30, 2023 21:13
@mlm483
Copy link
Contributor

mlm483 commented Dec 5, 2023

@dmeidlin Under "Importing Into Field Book", step 3, I'm assuming we should NOT see environments from other programs.

Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working.

@dmeidlin a few changes requested if you want to take a look.

src/router/index.ts Outdated Show resolved Hide resolved
src/views/BrAPI/BrAPIInfo.vue Outdated Show resolved Hide resolved
@mlm483 mlm483 changed the base branch from develop to release/0.9 January 25, 2024 17:57
@mlm483 mlm483 merged commit 345ffd1 into release/0.9 Jan 25, 2024
1 check passed
@mlm483 mlm483 deleted the feature/BI-1921 branch January 25, 2024 20:58
@mlm483 mlm483 restored the feature/BI-1921 branch January 25, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants