Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1927] - Entry Numbers Not Displaying #338

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[BI-1927] - Entry Numbers Not Displaying #338

merged 2 commits into from
Oct 30, 2023

Conversation

mlm483
Copy link
Contributor

@mlm483 mlm483 commented Oct 12, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1927

  • Fixed typo.

Testing

The bug occurred with old data that lacked the listEntryNumbers key in additionalInfo. The fix allows the frontend to fall-back on the importEntryNumber, as the import file represents the first/original list. (When support was added to DeltaBreed for multiple lists per Germplasm, the listEntryNumbers key was added). I've tested creating new lists with old germplasm data and it works; the first/original list position is stored by the importEntryNumber, while the subsequent lists will use listEntryNumbers. When testing locally you can use BreedBase and

  • upload Germplasm, with List name "NEW LIST",
  • delete the list external reference from the database using the SQL below,
  • go to the Germplasm List list view and ensure entry numbers are present.
-- Delete list external reference.
-- Will not remove listEntryNumbers from Germplasm, but breaks the link to a list.
DELETE FROM public.dbxref
WHERE 
    dbxref.dbxref_id =
    (
        SELECT xr.dbxref_id
        FROM
            public.dbxref xr
            JOIN
            sgn_people.list_dbxref lxr ON xr.dbxref_id = lxr.dbxref_id
            JOIN
            sgn_people.list l ON lxr.list_id = l.list_id
            JOIN
            public.db ON db.db_id = xr.db_id AND db.name = 'breedinginsight.org/lists'
        WHERE
            l.name LIKE 'NEW LIST%'
    )
;

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/6502014923

@github-actions github-actions bot added the bug Something isn't working label Oct 12, 2023
@mlm483 mlm483 marked this pull request as ready for review October 12, 2023 23:30
@mlm483 mlm483 requested review from a team, davedrp and dmeidlin and removed request for a team October 12, 2023 23:30
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developer Test Passed (by kludging the code to simulate the problem)

@mlm483 mlm483 merged commit 2c47821 into develop Oct 30, 2023
1 check passed
@mlm483 mlm483 deleted the bug/BI-1927 branch October 30, 2023 15:05
@mlm483 mlm483 mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants