Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-1799 - Updated Germplasm Import Preview Pagination #335

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

mlm483
Copy link
Contributor

@mlm483 mlm483 commented Sep 28, 2023

Description

Story: story in Jira

  • Made the default page size 200.
  • Removed the show all button.

I added a initialPageSize property to ImportTemplate with a default value to preserve the previous behavior while allowing consumers to pass their own default.

Testing

Upload a Germplasm file and ensure the preview table has a default page size of 200 and there is no show all button.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/6343050410

made page size 200 and removed show all button
@github-actions github-actions bot added the bug Something isn't working label Sep 28, 2023
@mlm483 mlm483 marked this pull request as ready for review September 28, 2023 18:54
@mlm483 mlm483 requested review from a team, timparsons and dmeidlin and removed request for a team September 28, 2023 18:54
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing, initial display looks good. When I changed the page size from the initial 200 to 20, pagination did not update, and stayed at 200 and on the second page. Here's my test file for reference:

1799_bi_germplasm_import_template_v8.xls

Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the issue Tim found is fixed.

fixed bug setting pagination default pageSize
@mlm483
Copy link
Contributor Author

mlm483 commented Oct 2, 2023

When testing, initial display looks good. When I changed the page size from the initial 200 to 20, pagination did not update, and stayed at 200 and on the second page. Here's my test file for reference:

1799_bi_germplasm_import_template_v8.xls

Thanks, pageSize was continually being set to 200. I used a different approach, I think it's much cleaner and all 3 upload types appear to have the desired preview behavior.

@mlm483 mlm483 requested review from timparsons and dmeidlin October 2, 2023 15:11
@mlm483 mlm483 changed the title [BI-1799] - Updated Germplasm Import Preview Pagination BI-1799 - Updated Germplasm Import Preview Pagination Oct 2, 2023
@mlm483 mlm483 merged commit 8853c48 into release/0.8.1 Oct 5, 2023
@mlm483 mlm483 deleted the bug/BI-1799-import branch October 5, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants