[BI-1923] Treatment factor missing from experimental ui #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedrp
requested review from
a team,
timparsons and
dmeidlin
and removed request for
a team
timparsons
requested changes
Sep 22, 2023
src/views/import/Dataset.vue
Outdated
Comment on lines
411
to
413
| if(unit.additionalInfo && unit.additionalInfo.treatments && unit.additionalInfo.treatments && unit.additionalInfo.treatments[0]){ | ||
| datasetTableRow.treatmentFactors = unit.additionalInfo.treatments[0].factor; | ||
| } |
There was a problem hiding this comment.
While treatment factors are stored for persistence to the brapi storage server, they are translated back to being in unit.treatments in ObservationUnitDAO.java. This code should reference that location in the ObservationUnit object rather than in additionalInfo
…ity instead of ObservationUnit::additionalInfo
timparsons
requested changes
Sep 29, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "bi-web", | |||
| "version": "v0.8.1+585", | |||
| "version": "v0.9.0+589", | |||
There was a problem hiding this comment.
Looks like you rebased from the develop branch. Can the two changes in the file be reverted?
| @@ -34,7 +34,7 @@ export class ObservationUnit { | |||
| observationUnitPosition?: ObservationUnitPosition; | |||
| externalReferences?: ExternalReferences; | |||
| additionalInfo?: any; | |||
| treatments?: any; | |||
| treatments?: string[]; | |||
There was a problem hiding this comment.
Why was this changed to an array of strings instead of leaving it as any?
There was a problem hiding this comment.
Thanks. Changed.
Upon review of BrAPI, 'any' is the preferred type.
timparsons
approved these changes
Sep 29, 2023
dmeidlin
approved these changes
Oct 2, 2023
|
Re-opening because it "Closed with unmerged commits" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1923 - Treatment factor missing from experimental ui
Dependencies
bi-api: develop branch
Testing
Import an experiment with treatment factor.
Display it.
There should now be a Treatment Factors column in the Observation Dataset (with data)
Checklist: