Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-1900 - Exp error message improvement #328

Merged
merged 3 commits into from
Sep 21, 2023
Merged

BI-1900 - Exp error message improvement #328

merged 3 commits into from
Sep 21, 2023

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Sep 13, 2023

Description

Story: BI-1900 - Exp error message improvement.

Dependencies

bi-api: develop branch

Testing

The Error Messages Before Preview should be as described in the source of truth

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp davedrp requested review from a team, timparsons and nickpalladino and removed request for a team September 13, 2023 19:53
@github-actions github-actions bot added the bug Something isn't working label Sep 13, 2023
@davedrp davedrp marked this pull request as ready for review September 14, 2023 19:50
Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davedrp Could we discuss this when you're available? Not sure I understand the intent of the card and what was done here.

@davedrp davedrp merged commit ba06813 into develop Sep 21, 2023
@davedrp davedrp deleted the bug/BI-1900 branch September 21, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants