Feature/bi 1817

[davedrp]

Description

BI-1817

Added Data Set tab and DataSet compoment to the Experiment Detail Screen

Dependencies

bi-api: feature/BI-1818 branch

Testing

• Go to the Experiment List.
• Choose and Experiment with more than one Observation Variable (some with observation data values, some without).
• EXPECTED RESULT: The Experiment Detail Screen should show a "Observation Data Set" tab and the Details and Summary Stats (see wire-frame ).
  [NOTE: The itemized observation units seen on the wire-frame are not part of this story)

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: <link to TAF run>

[mlm483]

The visual appearance of the summary stats could be more consistent with the rest of the UI and with the wireframe.

I recommend doing a case sensitive search for "DataSet" and replacing all instances with "Dataset" for consistency. Same for "dataSet" (replace with "dataset"). "Dataset"/"dataset" is already used across the application, I suggest we standardize on that.

For experiments with no phenotypes, I recommend either displaying a single "No phenotypes are defined for this experiment." message under the Observation Dataset tab, or else showing "0" for each summary stat rather than "N/A" . I think all the "N/A"s take up space without conveying much.

[mlm483]

Looks good to me.