-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BI-1465] 6.1 Observation Dataset Export File #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just had one question, see comment.
@@ -127,6 +127,7 @@ export default class ExperimentsObservationsTable extends Vue { | |||
|
|||
private filters: any = {}; | |||
private experimentCallStack?: CallStack; | |||
private biReferenceSource?: String = process.env.BRAPI_REFERENCE_SOURCE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used anywhere? If not, can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, and yes. removed. thanks!
While testing, I found a inconsistency. The "import" of Experiments & Observations allows alphanumeric values for 'row' and 'column' ( for example; row='A'). But the download will error-out unless theses values are numeric. |
Description
Story: BI-1465
The
ExperimentsObservationsTable
component Download button request was changed to send the trial id (instead of the dBId) to the GET export endpoint on the backend. Also, instead of sendingenvironments=ALL
, the environments param is simply omitted.Dependencies
bi-api
feature/BI-1465
Testing
see PR for feature/BI-1465
Checklist: