Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1465] 6.1 Observation Dataset Export File #318

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Conversation

dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Jun 6, 2023

Description

Story: BI-1465
The ExperimentsObservationsTable component Download button request was changed to send the trial id (instead of the dBId) to the GET export endpoint on the backend. Also, instead of sending environments=ALL, the environments param is simply omitted.

Dependencies

bi-api feature/BI-1465

Testing

see PR for feature/BI-1465

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just had one question, see comment.

@@ -127,6 +127,7 @@ export default class ExperimentsObservationsTable extends Vue {

private filters: any = {};
private experimentCallStack?: CallStack;
private biReferenceSource?: String = process.env.BRAPI_REFERENCE_SOURCE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere? If not, can it be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, and yes. removed. thanks!

@davedrp
Copy link
Contributor

davedrp commented Jun 6, 2023

While testing, I found a inconsistency. The "import" of Experiments & Observations allows alphanumeric values for 'row' and 'column' ( for example; row='A'). But the download will error-out unless theses values are numeric.

@dmeidlin dmeidlin merged commit b08e389 into release/0.8 Jun 8, 2023
@dmeidlin dmeidlin deleted the feature/BI-1465 branch June 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants