BI-1717 (View experiment: Details, Summary Stats, Actions) #316

davedrp · 2023-05-23T17:44:51Z

Description

Story: BI-1717 Sub-story of BI-1644 View experiment: Details, Summary Stats, Actions

Created ExperimentDAO.ts and ExperimentService.ts to fetch an individual experiment
Created ExperimentDetails.vue to display an Experiments details.

Dependencies

bi-api: feature/BI-1716 branch

Testing

(See Acceptance Criteria in BI-1644)

Checklist:

I have performed a self-review of my own code
I have tested my code and ensured it meets the acceptance criteria of the story
I have create/modified unit tests to cover this change
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to documentation
I have run TAF: <link to TAF run>

…AIUtils.java

… Title

timparsons

Just a couple of minor changes

timparsons · 2023-05-24T19:53:42Z

src/breeding-insight/dao/ExperimentDAO.ts

+        config.method = 'get';
+        config.programId = programId;
+        config.experimentId = experimentId;
+        config.params = {stats: true};


It might be worth adding a parameter to this method for stats instead of hard-coding it to true. The parameter will need to be propagated up so that it can be set from the ExperimentDetails component

timparsons · 2023-05-24T19:57:51Z

src/breeding-insight/model/Trial.ts

+  programName?: string;
+  startDate?: string;
+  trialPUI?: string;
+  additionalInfo?: AdditionalInfo;


I think this should be of type any to allow flexibility for future fields to be in the trial's additionalInfo

timparsons · 2023-05-24T19:58:25Z

src/breeding-insight/model/Trial.ts

+
+}
+export class AdditionalInfo {
+  createdDate?: string;
+  defaultObservationLevel?: string;
+  environmentsCount?: string;
+  germplasmCount?: number;
+
+  experimentNumber?: string;
+  experimentType?: string;
+
+  createdBy?: AdditionalInfoCreateBy;
+}
+
+export class AdditionalInfoCreateBy {
+  userName?: string;
+  userId?: string;


These aren't needed if the additionalInfo field is changed to be of type any

timparsons · 2023-05-24T20:06:35Z

src/components/experiments/ExperimentsObservationsTable.vue

+<!--   Per Shawn, remove this link in favor of wrapping the trial title in a link     -->
+<!--        <router-link v-bind:to="{name: 'experiment-details', params: {programId: activeProgram.id, experimentId: BrAPIUtils.getBreedingInsightId(props.row.data.externalReferences,'/trials')}}">-->
+<!--          Details-->
+<!--        </router-link>-->


Sounds good. I think this commented code should be removed then.

timparsons · 2023-05-24T20:08:27Z

src/views/germplasm/GermplasmDetails.vue

+    // console.log("TO");
+    // console.log(to);
+    // console.log("FROM");
+    // console.log(from);
+    // console.log("next");
+    // console.log(next);


Can these lines be removed?

timparsons · 2023-05-24T20:08:37Z

src/views/germplasm/GermplasmDetails.vue

@@ -155,6 +161,7 @@ export default class GermplasmDetails extends GermplasmBase {
  private germplasmLoading: boolean = true;

  mounted () {
+    console.log("-------mount----------");


Can this line be removed?

timparsons · 2023-05-24T20:08:47Z

src/views/germplasm/GermplasmDetails.vue

+
+      console.log(',.,,..,.,.,.,.,.,GERMPLASM ,.,,.,...,.,.,.,');
+      console.log(this.germplasm);
+


Can these lines be removed?

dmeidlin · 2023-05-26T15:24:33Z

src/breeding-insight/model/Trial.ts

+  // contacts?: Array<Contact>;
+  //datasetAuthorships?: Array<TrialNewRequestDatasetAuthorships>;


Remove the commented out fields if not needed

@dmeidlin I think they are commented out because the Contact and TrialNewRequestDatasetAuthorships types aren't in the code base, but these fields are a part of the BrAPI Trial model. Are you ok with leaving them in there with this in mind?

dmeidlin · 2023-05-26T15:32:38Z

src/breeding-insight/utils/BrAPIUtils.ts

+import {ExternalReferences} from "@/breeding-insight/brapi/model/externalReferences";
+
+export class BrAPIUtils {
+    static getBreedingInsightId(references: ExternalReferences, referenceSourcePath: string = ""): string | undefined {


Instead of typing the source as string with an empty string as default, would you mind making an ExternalReferenceSource enum and specify the arg as non-null?

This method was copied from GermplasmUtils. I think there are places in the code that don't specify a referenceSourcePath parameter (because it's intended to just be breedinginsight.org) hence why there is a default of an empty string.

Ah, I see. I'm fine leaving it as is, then.

dmeidlin · 2023-05-26T15:34:18Z

src/components/trait/TraitDetailPanel.vue

      if (this.data && this.data.synonyms && this.data.synonyms.length > 0) {
        // Up to synonymsMaxLength synonyms will be shown before , ... cutoff
        const synonyms = this.data.synonyms.slice(0, Math.min(this.data.synonyms.length, synonymsMaxLength)).join(", ");
+        console.log(synonyms);


a leftover console.log statement that needs to be deleted

dmeidlin · 2023-05-26T16:16:59Z

src/views/experiments-and-observations/ExperimentDetails.vue

+            <a class="dropdown-item"
+              v-on:click="downloadFile"
+            >
+              Download file
+            </a>


There is a component @/components/experiments/ExperimentObservationsDownloadButton.vue that can be used here for the Download link.

…l-down

davedrp added 7 commits May 22, 2023 16:42

[BI-1717] WIP

0edfd6a

[BI-1717] WIP

c5fa31c

[BI-1717] add 'Action' button pulldown

fcefcfd

[BI-1717] moved getBreedingInsightId() from GermplasmUtils.java to Br…

c7213e5

…AIUtils.java

[BI-1717] ] Clean code (reomove unused imports and variables, etc...)

95090ba

[BI-1717] moved Experiment Detail link from Details to the experiment…

0b7fcde

… Title

[BI-1717] Made to match source of truth

f715fd0

davedrp requested review from a team, timparsons and dmeidlin and removed request for a team May 23, 2023 17:44

github-actions bot added the feature label May 23, 2023

davedrp marked this pull request as ready for review May 23, 2023 18:29

[BI-1717] impliment Tim's PR change request for BI-1716

d474ae0

timparsons requested changes May 24, 2023

View reviewed changes

[BI-1717] PR fixes

7744dab

timparsons approved these changes May 25, 2023

View reviewed changes

dmeidlin reviewed May 26, 2023

View reviewed changes

[BI-1717] PR fixes

8bae711

dmeidlin reviewed May 26, 2023

View reviewed changes

[BI-1717] implemented Download. Moved 'Action' buttons out of the pul…

0e3cdc0

…l-down

davedrp force-pushed the feature/BI-1717 branch from a764186 to 0e3cdc0 Compare June 2, 2023 15:05

dmeidlin approved these changes Jun 5, 2023

View reviewed changes

davedrp merged commit e99a523 into develop Jun 5, 2023

davedrp deleted the feature/BI-1717 branch June 5, 2023 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BI-1717 (View experiment: Details, Summary Stats, Actions) #316

BI-1717 (View experiment: Details, Summary Stats, Actions) #316

davedrp commented May 23, 2023 •

edited

Loading

timparsons left a comment

timparsons May 24, 2023

timparsons May 24, 2023

timparsons May 24, 2023

timparsons May 24, 2023

timparsons May 24, 2023

timparsons May 24, 2023

timparsons May 24, 2023

dmeidlin May 26, 2023

timparsons May 26, 2023 •

edited

Loading

dmeidlin May 26, 2023

dmeidlin May 26, 2023

timparsons May 26, 2023

dmeidlin May 26, 2023

dmeidlin May 26, 2023

timparsons May 26, 2023

dmeidlin May 26, 2023


		console.log(',.,,..,.,.,.,.,.,GERMPLASM ,.,,.,...,.,.,.,');
		console.log(this.germplasm);

		// contacts?: Array<Contact>;
		//datasetAuthorships?: Array<TrialNewRequestDatasetAuthorships>;

BI-1717 (View experiment: Details, Summary Stats, Actions) #316

BI-1717 (View experiment: Details, Summary Stats, Actions) #316

Conversation

davedrp commented May 23, 2023 • edited Loading

Description

Dependencies

Testing

Checklist:

timparsons left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timparsons May 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davedrp commented May 23, 2023 •

edited

Loading

timparsons May 26, 2023 •

edited

Loading