Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-1779 - Import germplasm with unspecified breeding method #313

Merged
merged 1 commit into from
May 9, 2023
Merged

BI-1779 - Import germplasm with unspecified breeding method #313

merged 1 commit into from
May 9, 2023

Conversation

timparsons
Copy link
Member

@timparsons timparsons commented May 4, 2023 •
edited
Loading

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1779

Commented out code for enabling/disabling system breeding methods within a program.

Dependencies

bi-api/bug/BI-1779

Testing

  • Log in to a program with a user that is a breeder in that program
  • Navigate to Program Configuration
  • Navigate to Breeding Methods
  • Ensure that there is no button for "Choose Predefined Methods"

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/4884247833

@timparsons timparsons requested review from a team, davedrp and nickpalladino and removed request for a team May 4, 2023 14:48
@github-actions github-actions bot added the bug Something isn't working label May 4, 2023
@davedrp
Copy link
Contributor

davedrp commented May 5, 2023

passsed Developer-testing.

@timparsons timparsons merged commit 40b3ffd into develop May 9, 2023
@timparsons timparsons deleted the bug/BI-1779 branch May 9, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpalladino nickpalladino nickpalladino approved these changes

@davedrp davedrp davedrp approved these changes

Assignees

@davedrp davedrp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timparsons @davedrp @nickpalladino