Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BI-1741 - Genotype Import #305

Merged
merged 1 commit into from
Mar 16, 2023
Merged

BI-1741 - Genotype Import #305

merged 1 commit into from
Mar 16, 2023

Conversation

timparsons
Copy link
Member

@timparsons timparsons commented Mar 13, 2023 •
edited by jira bot
Loading

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1741

  • Update display of genotypes (genotypes are now returned as text value instead of number value)
  • Update Variant column name to Chromosome

Dependencies

bi-api bug/BI-1741
brapi bug/BI-1741
Mgdb2BrapiV2Impl bug/BI-1741

Testing

Test using instructions from BI-1650

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@timparsons timparsons requested review from davedrp and dmeidlin March 13, 2023 14:28
@github-actions github-actions bot added the bug Something isn't working label Mar 13, 2023
@davedrp
Copy link
Contributor

davedrp commented Mar 15, 2023

passed test

@timparsons timparsons merged commit 1c2e5c6 into develop Mar 16, 2023
@timparsons timparsons deleted the bug/BI-1741 branch March 16, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@davedrp davedrp davedrp approved these changes

Assignees

@davedrp davedrp

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timparsons @davedrp @dmeidlin