[BI-1617] Refactor Ontology table to use Buefy #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timparsons
requested changes
Mar 3, 2023
davedrp
approved these changes
Mar 8, 2023
timparsons
requested changes
Mar 8, 2023
Comment on lines
187
to
209
| private static makeTraitReqConfig(programId: string) { | ||
| let config: any = { | ||
| url: `${process.env.VUE_APP_BI_API_V1_PATH}/programs/${programId}/traits`, | ||
| method: 'get' | ||
| }; | ||
| return config; | ||
| } | ||
|
|
||
| private static makeTraitParams(sort: OntologySort, pagination: {pageSize: number, page: number}, filters?: any) { | ||
| let params: any = {}; | ||
|
|
||
| if (filters) { | ||
| params = filters; | ||
| } | ||
| if (sort.field) { | ||
| params['sortField'] = sort.field; | ||
| } | ||
| if (sort.order) { | ||
| params['sortOrder'] = sort.order; | ||
| } | ||
| if (pagination.page || pagination.page == 0) { //have to account for 0-index pagination since 0 falsy | ||
| params ['page'] = pagination.page; | ||
| } | ||
| if (pagination.pageSize) { | ||
| params['pageSize'] = pagination.pageSize; | ||
| } | ||
| params.full = true; | ||
|
|
||
| return params; | ||
| } |
There was a problem hiding this comment.
Curious as to why this block of code is in the service and not the DAO?
| v-on:paginate="paginationController.updatePage($event)" | ||
| v-on:paginate-toggle-all="paginationController.toggleShowAll(traitsPagination.totalCount.valueOf())" | ||
| v-on:paginate-page-size="paginationController.updatePageSize(parseInt($event,10))" | ||
| <SidePanelTableNew |
There was a problem hiding this comment.
Is the intent to rename this back to SidePanelTable once the old version has been completely removed from the codebase?
dmeidlin
force-pushed
the
feature/BI-1617
branch
from
11c62e5 to
ede8c73
Compare
timparsons
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1617, BI-1628, BI-1629
A new component
SidePanelTableBuefy.vuewas created that uses the Buefy table with search filter inputs at the column headings. The active and archived ontology tables were changed to use the new component. The TraitsService method was changed to search traits using the GET /traits endpoint instead POST /traits/search. The ontology mutations in the vuex sorting module were updated.Dependencies
bi-api
feature/BI-1629Testing
Please include any details needed for reviewers to test this code
Checklist: