Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/BI-1620 - Program Selection page doesn't show all programs if more than 50 exist #301

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Feb 6, 2023

Description

BI-1620 Program Selection page doesn't show all programs if more than 50 exist

Please include a summary of the change that was made.
Program Selection page now shows up to 1000-programs

Dependencies

br-api : develop branch

Testing

  1. GIVEN there are at least 50 active programs.
  2. WHEN log in with a user-account that has at least 20 active programs (or the System Admin)
  3. THEN on the Welcome screen, you should see all the programs listed( see screen capture below).

Screen Shot 2023-02-06 at 10 20 49 AM

  1. WHEN the user navigates to select a new program in the upper right hand corner (see screen capture below)

  2. THEN all of the programs should be listed.

  3. GIVEN the user selects the 'Programs' menu option
    <img width="608" alt="Screen Shot 2023-02-06 at 10 21 23 AM" src="https://user-images.githubusercontent.com/7815559/217015562-96f41aeb-fe99-494

Screen Shot 2023-02-06 at 10 41 36 AM

  1. THEN only the first 50 programs should be visible.
  2. GIVEN the user select the the 'Show All' button.

Screen Shot 2023-02-06 at 10 48 04 AM

9. THEN all active programs should be visible.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Feb 6, 2023
@davedrp davedrp requested review from dmeidlin, a team, timparsons and nickpalladino and removed request for dmeidlin and a team February 6, 2023 15:52
@davedrp davedrp marked this pull request as ready for review February 6, 2023 15:54
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me as a short term fix. BI-1706 has been created to implement a longer term fix

Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed programs code

@davedrp davedrp merged commit 5b92887 into develop Feb 13, 2023
@davedrp davedrp deleted the bug/BI-1620 branch February 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants