[BI-1606] Allow germplasm records to be in multiple lists #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedrp
approved these changes
Jan 31, 2023
timparsons
requested changes
Feb 1, 2023
| @@ -119,6 +121,9 @@ export default class GermplasmByList extends GermplasmBase { | |||
| const {result: {data: lists}} = await GermplasmDAO.getAllLists(this.activeProgram!.id!, paginationQuery); | |||
| const matchingLists: any[] = lists.filter(list => list.listDbId === this.$route.params.listId); | |||
| this.list = matchingLists[0]; | |||
| this.referenceId = matchingLists[0].externalReferences.reduce((result: string, ref: any) => { | |||
| return ref.referenceSource == "breeding-insight.net/lists" ? ref.referenceID : result; | |||
There was a problem hiding this comment.
the reference source root (aka breeding-insight.net in this line of code) is an environment variable: VUE_APP_BI_REFERENCE_SOURCE
timparsons
requested changes
Feb 2, 2023
dmeidlin
force-pushed
the
feature/BI-1606
branch
from
127da90 to
aeee15d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1606
The germplasm list details page now uses a helper function to display the entry number whether the number is stored using the old format of importEntryNumber or using the listEntryNumbers map.
Dependencies
bi-api feature/BI-1606 branch
Testing
Import germplasm with user-supplied entry numbers.
Go to the Germpasm Lists tab and use the dev tools console to inspect the list object in the response and verify there is an external reference entry for /lists and note the UUID stored as the refernceID.
Then view all imported germplasm and use the dev tools console to inspect the germplasm objects in the response from bi-api. Verify the additionalInfo field "listEntryNumbers" exists and the value is a Map with the imported list ID from step 2 as the key and entry number as value.
Import germplasm without user-supplied entry numbers and repeat process above.
Download the imported germplasm and verify the exported file records match what is stored.
Download a list of previously imported germplasm that store entry number values in additionalInfo.imortEntryNumber and verify the exported file records match what is stored.
Checklist: