Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1129] add fix for pagination bug #294

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[BI-1129] add fix for pagination bug #294

merged 1 commit into from
Jan 19, 2023

Conversation

dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Jan 13, 2023

Description

Story: BI-1129

When the filter state is updated for the germplasm table, the page is set to 1.

Dependencies

bi-api: develop

Testing

Go to an All Germplasm table with more than one page.
Go to any page other than page 1.
Apply a valid filter to any column.

Expected Result

Valid filtered Germplasm table should displayed
The Germplasm table should be on page 1

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Jan 13, 2023
@dmeidlin dmeidlin requested review from a team, timparsons, davedrp and nickpalladino and removed request for a team and timparsons January 13, 2023 22:54
@davedrp
Copy link
Contributor

davedrp commented Jan 19, 2023

dev-test passed

@dmeidlin dmeidlin merged commit 0967b2b into develop Jan 19, 2023
@dmeidlin dmeidlin deleted the bug/BI-1129 branch January 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants