Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1634] When filtering the list, set the page to page-1 #277

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Nov 4, 2022

Description

BI-1634 (Germplasm filtering and sorting fails for pages beyond the first)

Dependencies

bi_api: release/0.7

Testing

  1. Go to an All Germplasm table with more than one page.
  2. Go to any page other than page-1.
  3. Apply a valid filter to any column.

Expected Result

  1. Valid filtered Germplasm table should displayed
  2. The Germplasm table should be on page-1

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF

@davedrp davedrp requested review from a team, timparsons and HMS17 and removed request for a team November 4, 2022 19:40
@github-actions github-actions bot added the bug Something isn't working label Nov 4, 2022
@davedrp davedrp marked this pull request as ready for review November 4, 2022 19:42
initSearch(filter: any){
this.filters = filter;
// When filtering the list, set the page to page-1
this.paginationController.updatePage(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code seems to be setting the page to page 1, not page-1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the dash to be a hyphen, not a negative. But I you are 100% correct. It is, at best, confusing. I'll change it.

Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing passed. Approving assuming Heather's comment is addressed.

@HMS17 HMS17 self-requested a review November 7, 2022 15:52
@davedrp davedrp merged commit fe8261d into release/0.7 Nov 7, 2022
@davedrp davedrp deleted the bug/BI-1634 branch November 7, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants