Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1570] - Improve error reporting - Text to Table #275

Merged
merged 6 commits into from
Nov 1, 2022
Merged

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Oct 17, 2022

Description

Story: BI-1570 - Improve error reporting - Text to Table

Added ImportError class to handle previously in a list errors for import, and utilized it to display import errors in a sortable table.

Dependencies

bi-api/develop

Testing

For Germplasm, Ontology, and Experiment Import:

  • Import file that before now would give row errors, ie:
    -- Germplasm - invalid breeding methods, required field with empty values
    -- Ontology - Missing scale categories for nominal/ordinal scale, missing required fields, trait name duplicate,
    -- Experiment - Non-existing GID
  • See that errors now display in table
  • Check that table columns are sortable

(NOTE that frontend showAll is broken and will be resolved in another card)

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 changed the title [BI-1570] [BI-1570] - Improve error reporting - Text to Table Oct 17, 2022
@HMS17 HMS17 requested review from a team, dmeidlin and nickpalladino and removed request for a team October 17, 2022 19:22
@HMS17 HMS17 marked this pull request as ready for review October 31, 2022 19:23
@HMS17 HMS17 merged commit e5ab7b5 into develop Nov 1, 2022
@HMS17 HMS17 deleted the feature/BI-1570 branch November 1, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants