Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1198] All Experiments Table #254

Merged
merged 2 commits into from
Aug 8, 2022
Merged

[BI-1198] All Experiments Table #254

merged 2 commits into from
Aug 8, 2022

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Aug 1, 2022

Description

Story: BI-1198 - All Experiments Table

Created Experiments and Observations Table

  • Added ExperimentsAndObservations.vue and ExperimentsObservationsTable.vue component to display experiment information (download link and date created/created by to be implemented fully in future cards)
  • Included a button on ExperimentsAndObservations to link to experiment import
  • Modified UserSideBarLayout.vue and router/index.ts to redirect to ExperimentObservations.vue instead of Trials and Studies
  • Added fixed-width-wrapped to main.scss to constrain title and dataset column width
  • Modified TrialDAO.ts and TrialService.ts to pass in metadata parameter

NOTE
Presently this means the original Trials and Studies table components are no longer accessible via BI, but whether they should be deleted/deprecated is up for discussion.

Dependencies

bi-api/BI-1198-2

Testing

  • Check that Trials and Studies is no longer in left sidebar and is replaced with Experiments & Observations
  • Click on Experiments & Observations on program with no Experiments
  • Ensure "No experiments and observations are currently defined for this program." displays
  • Ensure Import Button displays
  • Click on button, should navigate to experiment import
  • Import experiments
  • Return to Experiments & Observations, experiment title, status, and datasets should display, and dataset and title columns should wrap

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 changed the base branch from develop to future/1.0 August 1, 2022 18:02
@HMS17 HMS17 marked this pull request as ready for review August 1, 2022 18:39
@HMS17 HMS17 requested review from a team, timparsons, davedrp and nickpalladino and removed request for a team and timparsons August 1, 2022 18:40
@HMS17 HMS17 force-pushed the feature/BI-1198-2 branch from b1fab65 to fd2db57 Compare August 3, 2022 14:31
@davedrp
Copy link
Contributor

davedrp commented Aug 3, 2022

passed developer testing

@HMS17 HMS17 merged commit 85ca7ff into future/1.0 Aug 8, 2022
@HMS17 HMS17 deleted the feature/BI-1198-2 branch August 8, 2022 13:47
timparsons pushed a commit that referenced this pull request Sep 15, 2022
timparsons pushed a commit that referenced this pull request Sep 29, 2022
timparsons pushed a commit that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants