Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1224] - Show list creator in Germplasm lists table #244

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jun 23, 2022

Description

Story: BI-1224 - Show list creator in Germplasm lists table

Retrieves list creator and displays for germplasm lists.

Added Created By column in Germplasm Lists table that takes in listOwnerName
Changed Date Created to Created Date to be more consistent with other tables

Dependencies

bi-api/BI-1224

Testing

For breedbase and brapi test server:

  • Import germplasm under two different users
  • Go to germplasm list table
  • Created By column should exist
  • Column should display name of correct user that imported germplasm list

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 requested review from a team, timparsons and davedrp and removed request for a team and timparsons June 27, 2022 20:57
@HMS17 HMS17 requested a review from ctucker3 June 27, 2022 20:59
@HMS17 HMS17 marked this pull request as ready for review June 27, 2022 20:59
@HMS17 HMS17 merged commit 09ae794 into develop Jul 5, 2022
@HMS17 HMS17 deleted the feature/BI-1224 branch July 5, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants