[BI-1191] Germplasm Search #242
Conversation
ctucker3
force-pushed
the
feature/BI-1191
branch
from
132bb68 to
c2ef3c8
Compare
| async getGermplasm() { | ||
| this.germplasmLoading = true; | ||
| try { | ||
| const response = await BrAPIService.get(BrAPIType.GERMPLASM, {}, this.activeProgram!.id!, | ||
| this.paginationController.pageSize, this.paginationController.currentPage - 1); | ||
| if (this.paginationController.showAll) { |
There was a problem hiding this comment.
I removed this if statement block as part of BI-1401 which among other things switched GermplasmTable from using PaginationController to using BackendPaginationController, which handled update of the paginationcontroller values. Is there a particular reason why this code was reinstated, and should that function maybe be part of BackendPaginationController instead so it doesn't get repeated across multiple tables?
There was a problem hiding this comment.
That section had a merge conflict, so I think it was probably reintroduced from there. Thanks for catching that! I'll look into removing it.
There was a problem hiding this comment.
I removed that if statement and tested it to make sure the pagination still works. Everything still works!
timparsons
force-pushed
the
feature/BI-1191
branch
from
c0a3377 to
13a1ba3
Compare
Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1191
CallStackclass that could be a good replacement for current pagination request behavior.Dependencies
biapi: BI-1191
Testing
See biapi PR.
Checklist: