[BI-1347] - Germplasm pedigree view #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timparsons
requested review from
HMS17,
a team and
dmeidlin
and removed request for
a team
timparsons
requested review from
a team,
dmeidlin and
ctucker3
and removed request for
dmeidlin and
a team
HMS17
requested changes
Jun 10, 2022
There was a problem hiding this comment.
https://breedinginsight.atlassian.net/browse/BI-1503 created to handle case of brapi test server programs.
| private pedigreeWrapId: String = 'pedigree-wrap'; | ||
|
|
||
| private activeProgram?: Program; | ||
| private pedigreeLoading: boolean = true; //todo add loading symbol when loading |
There was a problem hiding this comment.
todo should be removed if loading symbol works
src/store/index.ts
Outdated
| @@ -71,7 +71,6 @@ const store: StoreOptions<RootState> = { | |||
| successNotificationMsg: state => { | |||
| return state.successNotificationMsg; | |||
| }, | |||
There was a problem hiding this comment.
This and mutations.js seem to be leftover changes.
HMS17
approved these changes
Jun 13, 2022
ctucker3
approved these changes
Jun 13, 2022
- utilizing credentials: include to allow BI auth token to be sent to bi-api - Updated GermplasmPedigreesView component to fetch the germplasm record on load if a dbid isn't passed in. - Updated pedigree tree viewer to take up the full width of the container
timparsons
force-pushed
the
feature/BI-1347
branch
from
df3cc62 to
f08de48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1347 - Germplasm Pedigree View
Integrated the BrAPI Pedigree Viewer into the germplasm view.
Implementation notes:
brapi-js,brapi-pedigree-viewer, andd3-pedigree-treedependenciesNOTE: Before merging this PR:
Out of scope:
Dependencies
Testing
Has been tested during development with a program pointed to Breedbase only (hasn't been tested on the BrAPI Java Server)
Checklist: