Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bi 1459 #232

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Feature/bi 1459 #232

merged 4 commits into from
Jun 7, 2022

Conversation

timparsons
Copy link
Member

@timparsons timparsons commented May 23, 2022

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1459

Created a page to view the status of asynchronous jobs that have been submitted for a given program. Updated the job submission pages (germplasm import, brapi import) to show a message after a job is submitted telling the user they can navigate away from the page, and view the status of the job on the new job status page.

Also removed some of the clutter on the welcome screen for now until we decide what content we want on the welcome screen.

Dependencies

bi-api: features/BI-1459

Testing

Job status does not show for ontology upload, as that does not use the import tables to store the status of the upload.

  • Upload a file via the germplasm uploader, or the BrAPI import tool
  • Confirm the import was submitted successfully
  • A warning styled message should be displayed at the top of the import page indicating the job has been submitted, and status can be checked on the jobs page
  • Navigate to the jobs page (should be a menu item for this)
  • Verify the job that was just submitted displays in the list of jobs
  • Refresh the page until the job status completes (either successfully or in error)
  • If successful, there should be a green pill for the row with the word "Finished"
  • If failed, there should be a red pill for the row with the word "Error"

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase NA
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/2423334177

@timparsons timparsons requested review from a team, davedrp and HMS17 and removed request for a team May 27, 2022 13:45
@timparsons timparsons marked this pull request as ready for review May 27, 2022 13:45
@timparsons timparsons requested review from davedrp and removed request for davedrp May 27, 2022 13:45
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add a breakpoint to catch the In Progress tag, but it seems to be working!

@davedrp
Copy link
Contributor

davedrp commented Jun 3, 2022

happy path test passed

@timparsons timparsons merged commit f32a216 into develop Jun 7, 2022
@timparsons timparsons deleted the feature/BI-1459 branch June 7, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants