Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-1146 #224

Merged
merged 5 commits into from
Jun 10, 2022
Merged

BI-1146 #224

merged 5 commits into from
Jun 10, 2022

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented May 5, 2022

Description

Story: BI-1146 Upload & Validate Independent Variables for New Experiment

NOTE
The processing of columns Pheno 1 (Phenotype) and TS:Pheno 1 (Observation Timestamp) has been removed from this story.

Dependencies

bi-api branch Feature/bi 1146

Testing

  • Given that the user is on the Experiments & Observations tab of the Import File page
  • AND the user select an import file with missing required fields, and an invalid GID.
  • THEN the user should see appropriate error messages
  • AND the confirmation page should reflect the wireframe

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp davedrp requested review from a team, dmeidlin and nickpalladino and removed request for a team May 5, 2022 20:30
Copy link
Contributor

@dmeidlin dmeidlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I import a test file with data in all required fields, the preview is successful, but when I click on Import a 400 response is returned with the message; "Required Body [userInput] not specified"

@davedrp
Copy link
Contributor Author

davedrp commented May 31, 2022

@dmeidlin The ability to save the import data is outside scope of this story ( See BI-1189 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants