[BI-1420] Add synonym to germplasm import and export #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctucker3
force-pushed
the
feature/BI-1420
branch
from
969539b to
2860a3a
Compare
HMS17
approved these changes
May 2, 2022
| @@ -43,4 +43,9 @@ export class GermplasmUtils { | |||
| return val ? val.referenceID : ""; | |||
| } | |||
|
|
|||
| static formatSynonyms(synonyms: any[]): string { | |||
| if (!synonyms) return ""; | |||
| return synonyms.map(synonym => synonym.synonym).join(";"); | |||
There was a problem hiding this comment.
might look a little nicer with a space after the semicolon, your call
ctucker3
force-pushed
the
feature/BI-1420
branch
2 times, most recently
from
082738e to
733c402
Compare
nickpalladino
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1420
Dependencies
biapi: BI-1420
Testing
See biapi PR
Checklist: