[BI-1366] Subscribe Ontology #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctucker3
force-pushed
the
feature/BI-1366
branch
from
bb7a10a to
288ad3e
Compare
ctucker3
requested review from
a team,
timparsons and
dmeidlin
and removed request for
a team
timparsons
requested changes
Apr 7, 2022
| * limitations under the License. | ||
| */ | ||
|
|
||
| export class SubscribedProgram { |
There was a problem hiding this comment.
Can this be renamed to SubscribedOntology?
There was a problem hiding this comment.
renamed along with SharedOntology and SharedOntologyRequest
| <p>You cannot subscribe to another programs ontology when you have shared your own program's ontology.</p> | ||
| </template> | ||
| <template v-else-if="hasTraits"> | ||
| <p>This program contains traits and so cannot subscribe to another program's ontology.</p> |
There was a problem hiding this comment.
wording suggestion: change "...and so cannot..." to "...and therefore cannot..."
dmeidlin
approved these changes
Apr 8, 2022
timparsons
approved these changes
Apr 13, 2022
added 9 commits
April 19, 2022 16:07
ctucker3
force-pushed
the
feature/BI-1366
branch
from
c0213b9 to
53f913e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1366
Added the ability for a program to subscribe to an ontology. Add checks and UI indicators for the following error conditions:
Dependencies
biapi: BI-1366
Testing
observationtable for the brapi server.Checklist: