Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-1363] Program Configuration and Share Ontologies #214

Merged
merged 7 commits into from
Apr 5, 2022
Merged

[BI-1363] Program Configuration and Share Ontologies #214

merged 7 commits into from
Apr 5, 2022

Conversation

ctucker3
Copy link
Contributor

Description

Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1363

  • Added a Program Configuration page
  • Create a Shared Ontology component
  • Handled errors coming back from the shared ontology endpoints.

Dependencies

biapi: BI-1363

Testing

See biapi PR for testing details, Breeding-Insight/bi-api#166.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@ctucker3 ctucker3 requested review from a team, davedrp and dmeidlin and removed request for a team March 28, 2022 20:35
@davedrp
Copy link
Contributor

davedrp commented Mar 30, 2022

passed testing

@HMS17 HMS17 self-assigned this Apr 5, 2022
@HMS17 HMS17 self-requested a review April 5, 2022 16:29
@HMS17 HMS17 removed their assignment Apr 5, 2022
@ctucker3 ctucker3 merged commit 2f7a7f3 into develop Apr 5, 2022
@ctucker3 ctucker3 deleted the feature/BI-1363 branch April 5, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HMS17 HMS17 HMS17 approved these changes

@dmeidlin dmeidlin dmeidlin approved these changes

@davedrp davedrp Awaiting requested review from davedrp davedrp was automatically assigned from Breeding-Insight/dev-team

Assignees

@davedrp davedrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctucker3 @davedrp @dmeidlin @HMS17