Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1369] enable backend sorting for roles column of program users table #196

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Feb 28, 2022

Description

Story: BI-1369

  • Backend sorting enabled for roles column of program user's table
  • Vuex sort module getter for program users updated to include roles

Dependencies

release/0.5 bi-api
backend code for sorting on user roles already in place, so only front-end changes

Testing

  1. add several users of different roles and click on roles header to toggle sort order
  2. navigate to locations tab and back to users tab and verify that sort state for users table has not changed

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Feb 28, 2022
@dmeidlin dmeidlin requested review from a team, timparsons and ctucker3 and removed request for a team February 28, 2022 17:11
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing passes

@dmeidlin dmeidlin merged commit 07552eb into release/0.5 Mar 7, 2022
@dmeidlin dmeidlin deleted the bug/BI-1369 branch March 7, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants