Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-1338] - Germplasm Import Template references DBID instead of GID #190

Merged
merged 2 commits into from
Feb 21, 2022
Merged

[BI-1338] - Germplasm Import Template references DBID instead of GID #190

merged 2 commits into from
Feb 21, 2022

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Feb 17, 2022 •
edited
Loading

Description

Story: ISSUE: Germplasm Import Template README still references DBID instead of GID

Replaced remaining instances of DBID with GID in README.

Dependencies

bi-api-develop

Testing

Go to germplasm import, download template, look at readme. All instances of DBID should be replaced with GID.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • [n/a] I have create/modified unit tests to cover this change
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Feb 17, 2022
@HMS17 HMS17 marked this pull request as ready for review February 17, 2022 16:58
@HMS17 HMS17 requested review from a team, timparsons and davedrp and removed request for a team February 17, 2022 16:59
@HMS17 HMS17 changed the base branch from develop to release/0.5 February 17, 2022 20:53
@HMS17 HMS17 requested review from a team and dmeidlin and removed request for timparsons and a team February 18, 2022 15:38
@HMS17 HMS17 assigned dmeidlin and unassigned timparsons Feb 18, 2022
@HMS17 HMS17 merged commit b1c525f into release/0.5 Feb 21, 2022
@HMS17 HMS17 deleted the bug/BI-1338 branch February 21, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmeidlin dmeidlin dmeidlin approved these changes

@davedrp davedrp davedrp approved these changes

Assignees

@dmeidlin dmeidlin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HMS17 @davedrp @dmeidlin @timparsons