[BI-1373] ontology import: fix banners #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctucker3
requested review from
a team,
timparsons and
dmeidlin
and removed request for
a team
timparsons
approved these changes
Feb 21, 2022
dmeidlin
approved these changes
Feb 21, 2022
ctucker3
force-pushed
the
bug/BI-1373
branch
from
60d5955 to
bf55574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?selectedIssue=BI-1373
Simple fix to pass through all listeners for ontology import component.
Dependencies
bi-api:develop
Testing
Run the tests from the card. Here are two files you can use:
BI_1373_bad_traits.xls
BI_1373_good_traits.xls
Checklist: