Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-1258] prevent categories array from being zeroed out. #174

Merged
merged 1 commit into from
Feb 1, 2022
Merged

[BI-1258] prevent categories array from being zeroed out. #174

merged 1 commit into from
Feb 1, 2022

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Jan 21, 2022 •
edited
Loading

Description

Story: BI-1258

The updateCategories() in CategoryTraitForm.vue was zeroing out the catigories array

Dependencies

None

Testing

see BI-1258

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF.

@davedrp davedrp requested review from a team, timparsons and HMS17 and removed request for a team January 21, 2022 19:25
@davedrp davedrp merged commit 0155c5f into develop Feb 1, 2022
@davedrp davedrp deleted the feature/BI-1258 branch February 1, 2022 17:02
@davedrp
Copy link
Contributor Author

davedrp commented Feb 1, 2022

TAF test show now new errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HMS17 HMS17 HMS17 approved these changes

@timparsons timparsons timparsons approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davedrp @timparsons @HMS17