Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1253] - Ordinal Label Value Swap Details View #171

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jan 18, 2022

Description

Story: BI-1253 - ISSUE - Ordinal scale class label and value are swapped on UI - details view

Logic fix to display value followed by label in ordinal scale list in ontology details side panel.

Dependencies

  • n/a

Testing

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • [n/a] I have create/modified unit tests to cover this change
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to documentation
  • I have run TAF.

@github-actions github-actions bot added the bug Something isn't working label Jan 18, 2022
@HMS17 HMS17 marked this pull request as ready for review January 18, 2022 18:41
@HMS17 HMS17 requested review from a team, davedrp and ctucker3 and removed request for a team January 18, 2022 18:42
Copy link
Contributor

@ctucker3 ctucker3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the testing for this one because I wanted to make sure the label and value weren't switched in brapi so that field book would still work properly.

Bug fix works as expected. The trait details page is looking clunky these days because of the different alignments, but that doesn't have to do with this card.

@HMS17 HMS17 merged commit 384d25a into develop Jan 24, 2022
@HMS17 HMS17 deleted the bug/BI-1253 branch January 24, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants