Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1219] Changing Parent DB ID to Parent GID #166

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

ctucker3
Copy link
Contributor

@ctucker3 ctucker3 commented Jan 6, 2022

Description

Story: (https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1219)

Changes Parent DB ID references to Parent GID. There was no references on the UI. In the import germplasm table the parents are under "Pedigree". Only the import template needed to be changed.

Dependencies

biapi: BI-1219 (Breeding-Insight/bi-api#132)

Testing

  1. This file with import germplasm into your brapi system:
    BI-1219_few_germplasm_in_file_parents.xls

  2. This file will make GID references to those germplasm you just imported:
    BI-1219_few_germplasm_db_parents.xls

  3. Try out the old template to see the error message you will get:
    BI-1056_few_germplasm.xls

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF.

@ctucker3 ctucker3 merged commit 0b8c705 into develop Jan 18, 2022
@ctucker3 ctucker3 deleted the feature/BI-1219 branch January 18, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants