[BI-1056] All Germplasm Table #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2022
ctucker3
requested review from
a team,
timparsons and
davedrp
and removed request for
a team
timparsons
requested changes
Jan 6, 2022
Comment on lines
20
to
21
| import {ResultGenerator} from "@/breeding-insight/model/Result"; | ||
| import {Germplasm} from "@/breeding-insight/brapps/reporter/model/germplasm"; |
There was a problem hiding this comment.
These imports aren't used and could be removed
src/views/germplasm/Germplasm.vue
Outdated
| tag="li" | ||
| active-class="is-active" | ||
| > | ||
| <a>Germplasm</a> |
There was a problem hiding this comment.
Per the story, this text should be "All Germplasm"
src/router/index.ts
Outdated
| path: 'germplasm-all', | ||
| name: 'germplasm-all', | ||
| meta: { | ||
| title: 'Germplasm', |
There was a problem hiding this comment.
Per the techspecs, this text should be "All Germplasm"
| <template> | ||
| <section id="germplasmTable"> | ||
| <h1 class="title"> | ||
| Germplasm |
There was a problem hiding this comment.
This should probably be "All Germplasm" to match the nav
timparsons
approved these changes
Jan 10, 2022
davedrp
approved these changes
Jan 10, 2022
added 12 commits
January 11, 2022 13:37
ctucker3
force-pushed
the
feature/BI-1056
branch
from
cfa98fc to
ef0fd44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Story: (https://breedinginsight.atlassian.net/jira/software/c/projects/BI/boards/1?modal=detail&selectedIssue=BI-1056)
Includes:
Dependencies
sgn: BI-1056 (Breeding-Insight/sgn#50)
bi-api: BI-1056 (Breeding-Insight/bi-api#130)
bi-web: BI-1056 (#165)
Testing
Use the importer and the file below to import some germplasm. Play around with the table and try some paging out to make sure everything works.
BI-1056_lots_of_germplasm.xls
TAF Results
The taf job seems to be broken and is not printing out results.
Checklist: