Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-1254] git trait tags and synonyms default values #160

Merged
merged 1 commit into from
Dec 9, 2021
Merged

[BI-1254] git trait tags and synonyms default values #160

merged 1 commit into from
Dec 9, 2021

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Dec 9, 2021

for https://breedinginsight.atlassian.net/browse/BI-1254

The back-end should be release/0.4

@davedrp davedrp requested review from a team, ctucker3 and nickpalladino and removed request for a team December 9, 2021 15:07
@github-actions github-actions bot added the bug Something isn't working label Dec 9, 2021
ctucker3
ctucker3 approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@ctucker3 ctucker3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I also tested it with the scenarios in the JIRA card and confirmed that those scenarios are no longer an issue.

@davedrp davedrp merged commit e8a2d53 into release/0.4 Dec 9, 2021
@davedrp davedrp deleted the bug/BI-1254 branch December 9, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpalladino nickpalladino nickpalladino approved these changes

@ctucker3 ctucker3 ctucker3 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davedrp @ctucker3 @nickpalladino