Bug/bi 1158 #152
Bug/bi 1158 #152
Conversation
davedrp
requested review from
a team,
dmeidlin and
ctucker3
and removed request for
a team
| if (this.data && this.data.abbreviations && this.data.abbreviations.length > 0) { | ||
| abbSyn = this.data.abbreviations[0]; | ||
| } | ||
|
|
||
| if (this.data && this.data.synonyms && this.data.synonyms.length > 0) { | ||
| // Up to synonymsMaxLength synonyms will be shown before , ... cutoff | ||
| const synonyms = this.data.synonyms.slice(0, Math.min(this.data.synonyms.length, synonymsMaxLength)).join(", "); |
There was a problem hiding this comment.
Are all of these abbreviation changes intended for this card? The card you linked was only for the changed file template.
There was a problem hiding this comment.
After a conversation with Tim, I removed all references to the abbreviation data element. (I have now added a brief comment to the Jira story )
|
What branch of bi-api should I be running this on? When running on develop with the file below I get the error in the image:
|
There is a bug/bi-1158 branch in bi-api |
src/breeding-insight/model/Trait.ts
Outdated
| @@ -29,7 +29,7 @@ export class Trait { | |||
| traitDescription?: string; | |||
| method?: Method; | |||
| scale?: Scale; | |||
| abbreviations?: Array<string>; | |||
| //abbreviations?: Array<string>; | |||
There was a problem hiding this comment.
Looks like a line that was commented out initially and should now be deleted.
see https://breedinginsight.atlassian.net/browse/BI-1158