[BI-1127] Ontology UI Form: ordinal & nominal #137
Conversation
dmeidlin
force-pushed
the
feature/BI-1127
branch
from
c08bbf4 to
fb02b49
Compare
| @@ -186,7 +186,14 @@ export default class CategoryTraitForm extends Vue { | |||
| } | |||
|
|
|||
| removeRow() { | |||
| this.data.splice(this.activeRemoveRowIndex!,1); | |||
There was a problem hiding this comment.
Should there be a notification if you try and delete a row and can't so that the user knows why?
There was a problem hiding this comment.
That's a good point, but I think a notification is a little aggressive Making the X icon look disabled once the minimum is reached should be enough to be clear in this case without confusing the user. What do you think?
There was a problem hiding this comment.
ya, or other thought I had was some red status text like when you get a validation error.
There was a problem hiding this comment.
Or even better, just remove the X button for the first one or two categories.
There was a problem hiding this comment.
I made it so the delete buttons don't show for the minimum categories. Have a look and see what you think. I'm open to trying the validation text, too.
There was a problem hiding this comment.
I added the helper text 'Nominal scales require at least one category' and 'Ordinal scales require at least two categories' to the respective minimum input fields.
…orfinal and nominal
dmeidlin
force-pushed
the
feature/BI-1127
branch
from
4d8d9d1 to
e39c223
Compare
Placeholder text was changed to 'Value' and 'Category' for nominal and ordinal scale classes.
Minimum of 1 category for nominal scale and 2 categories for ordinal scale is enforced.