Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bi 760 #134

Merged
merged 18 commits into from
Oct 20, 2021
Merged

Feature/bi 760 #134

merged 18 commits into from
Oct 20, 2021

Conversation

davedrp
Copy link
Contributor

@davedrp davedrp commented Oct 18, 2021

No description provided.

@davedrp davedrp requested review from a team, timparsons and HMS17 and removed request for a team October 18, 2021 17:35
davedrp added 17 commits October 19, 2021 13:24
@davedrp
BI-760 Include changes for AdminProgramTable.vue
e79efca 
remove unnecessary dependencie '@vue/cli: ^4.5.13'
@davedrp
BI-760 added DEACTIVATE_ALL_NOTIFICATIONS, a convenience store mutato…
4aaf64a 
…r that will close all of the notificaton boxes. Added new mutators to moke store in tests/unit/components/notifications.spec.ts.
@davedrp
BI-760 fixed bug found in test
e4a775d
@davedrp
BI-760 Added mutator 'deactivateAllNotifications' to defaltStore to r…
d872374 
…educe console noise durring unit test.
@davedrp
[BI-760] Handle 'New User' in Admin. Cleaned up AdminUsersTable test …
efbcf7f 
…to reduce console warnings

[BI-760] debugging test

[BI-760] logging it test

[BI-760] logging in DataForm.vue

[BI-760] more logging in DataForm.vue

[BI-760] removed logging in DataForm.vue

[BI-760] added back dependency "@vue/cli": "^4.5.13"

updated package-lock.json
@davedrp
[BI-760] rollback package.json
2d4333b 
[BI-760] added debug statement in test

[BI-760] improved catch output

[BI-760] comment out alot

[BI-760] WIP
@davedrp
[BI-760] use veux '...mapGetter' in notifications
012fc43
@davedrp
[BI-760] make build.yml and package.json look like remote versions
b51e124
@davedrp
BI-760 rebase with develop
fa3614d
@davedrp
[BI-760 - DaveP] removed AdminUsersTable unit test
d36f628
@davedrp
BI-760 Include changes for AdminProgramTable.vue
722d10c 
remove unnecessary dependencie '@vue/cli: ^4.5.13'
@davedrp
BI-760 added DEACTIVATE_ALL_NOTIFICATIONS, a convenience store mutato…
f450ba3 
…r that will close all of the notificaton boxes. Added new mutators to moke store in tests/unit/components/notifications.spec.ts.
@davedrp
BI-760 fixed bug found in test
41b932e
@davedrp
BI-760 Added mutator 'deactivateAllNotifications' to defaltStore to r…
0dd009a 
…educe console noise durring unit test.

[BI-760] logging in DataForm.vue

[BI-760] more logging in DataForm.vue

[BI-760] removed logging in DataForm.vue

updated package-lock.json

[BI-760] rollback package.json
@davedrp
[BI-760] fixed store in notifications.spec.ts
1217d87
@davedrp
[BI-760 - Dave P] clean up code
0681ff4
@davedrp
[BI-760 - DaveP] Warning Notification is not used, so has been remove…
ddb9ce1 
…d from App.vue
@davedrp
Copy link
Contributor Author

davedrp commented Oct 20, 2021

The unit test tests/unit/components/admin/AdminUsersTable.spec.ts has been removed.
The test is covered in the TAF scenario: Adding new user with no system role (in UserManagementSysAd.feature)

@davedrp davedrp merged commit b4b33c4 into develop Oct 20, 2021
@davedrp davedrp deleted the feature/BI-760 branch October 20, 2021 19:15
@timparsons timparsons restored the feature/BI-760 branch October 29, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HMS17 HMS17 HMS17 approved these changes

@timparsons timparsons timparsons approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davedrp @timparsons @HMS17