Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BI-997 BI-1061]-2 Update Trait Import (clean redo) #125

Merged
merged 7 commits into from
Sep 17, 2021
Merged

[BI-997 BI-1061]-2 Update Trait Import (clean redo) #125

merged 7 commits into from
Sep 17, 2021

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Sep 17, 2021 •
edited
Loading

Ontology Changes

  • Replace "Trait" with "Ontology" in Trait Import
  • Alter table columns in Trait Import according to specifications
  • Changed "traits" to "ontology terms" in modal message and banner messages

Linked to PR taf/BI-997
Redo of PR bi-web/BI-997

@HMS17 HMS17 mentioned this pull request Sep 17, 2021
Closed
@HMS17 HMS17 marked this pull request as ready for review September 17, 2021 13:35
nickpalladino
nickpalladino reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the table unit tests are failing, you figuring it out?

@HMS17
Copy link
Contributor Author

HMS17 commented Sep 17, 2021 •
edited
Loading

Looks like some of the table unit tests are failing, you figuring it out?

I'm looking into it. For some reason the name column isn't retrieving the name

@HMS17
Copy link
Contributor Author

HMS17 commented Sep 17, 2021

Looks like some of the table unit tests are failing, you figuring it out?

I'm looking into it. For some reason the name column isn't retrieving the name

Thanks for the help in fixing the tests @nickpalladino !

timparsons
timparsons requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to a comment Nick left in the original pull request, in TraitUploadService.ts, the constant forbiddenUploadingFile references "trait", and should probably be updated to "ontology term"

src/views/trait/TraitsImport.vue Outdated
v-bind:template-url="'https://cornell.box.com/shared/static/u9vuob3vvu2cgwyoe26b2722u41b8f6o.xls'"
<h1 class="title" v-if="showTitle">Import Ontology</h1>
<ImportInfoTemplateMessageBox v-bind:import-type-name="'Ontology'"
v-bind:template-url="'https://cornell.box.com/shared/static/8sp0qvccpjotosiv8576tczeg09nnvao.xls'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template link is to v9. The previous link is to v10. I think we want v10 as the link, @dmeidlin can you verify?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v10 has the new required fields for the ontology mvp, so, yes, keep the previous link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rectified

@HMS17
Copy link
Contributor Author

HMS17 commented Sep 17, 2021

Similar to a comment Nick left in the original pull request, in TraitUploadService.ts, the constant forbiddenUploadingFile references "trait", and should probably be updated to "ontology term"

Added changes.

@HMS17 HMS17 merged commit c844a2a into develop Sep 17, 2021
@HMS17 HMS17 deleted the feature/BI-997-BI-1061 branch September 17, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmeidlin dmeidlin dmeidlin left review comments

@nickpalladino nickpalladino nickpalladino approved these changes

@timparsons timparsons timparsons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HMS17 @timparsons @dmeidlin @nickpalladino