Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1014] - Banner Class Modifications #101

Merged
merged 2 commits into from
Jul 23, 2021
Merged

[BI-1014] - Banner Class Modifications #101

merged 2 commits into from
Jul 23, 2021

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jul 14, 2021

To make TAF selectors more robust against changing layouts, adding a “banner-text” value for the HTML class attribute that will be associated with the message in a banner for the following banner components:

  • ErrorNotification.vue
  • WarningNotification.vue
  • SuccessNotification.vue
  • InfoNotification.vue

This issue is linked to taf/BI-1014

@HMS17 HMS17 changed the title [BI-1014] - Classes added for banner text [BI-1014] - Banner Class Modifications Jul 20, 2021
@HMS17 HMS17 marked this pull request as ready for review July 22, 2021 23:24
@HMS17 HMS17 merged commit bee5c74 into develop Jul 23, 2021
@HMS17 HMS17 deleted the feature/BI-1014 branch July 23, 2021 20:09
timparsons pushed a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants