Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-895] - Convert the program user's table to use Buefy data tables #100

Merged
merged 5 commits into from
Jul 26, 2021

Conversation

timparsons
Copy link
Member

@timparsons timparsons commented Jul 9, 2021

The program user's table now uses Buefy's Table component (https://buefy.org/documentation/table/). Rather than implementing Buefy's table directly in ProgramUsersTable or modifying ExpandableRowTable, a new component named ExpandableTable was created. The main reason for not modifying ExpandableRowTable was to limit the scope of impact to just ProgramUsersTable rather than the entire UI, and to allow for each table currently using that component to be migrated and tested individually and incrementally.

The ProgramUsersTable should have feature parity with the original implementation. In addition, columns can now be sorted.

All features of Buefy Table should be accessible to client code using ExpandableTable, as the $attrs are passed through to Buefy Table. As an example, Buefy Table allows configuration to indicate if data is loading, but ExpandableTable does not have to have an explicit property defined to set this (ProgramUsersTable does set the loading value).

Known bugs

Future Development

  • Convert all existing ExpandableRowTable usages to ExpandableTable
  • Create a component for the side panel table that uses Buefy table

@timparsons timparsons requested review from a team, dmeidlin and ctucker3 and removed request for a team July 9, 2021 00:08
@timparsons timparsons requested review from nickpalladino and removed request for ctucker3 July 9, 2021 00:08
@timparsons timparsons marked this pull request as draft July 9, 2021 03:14
@timparsons timparsons marked this pull request as ready for review July 21, 2021 17:36
Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have cards for the identified bugs and future work?

@timparsons
Copy link
Member Author

Do we have cards for the identified bugs and future work?

I've created issues for the known bugs, and will create stories for future development next week. Thanks!

@timparsons timparsons merged commit d084237 into develop Jul 26, 2021
@timparsons timparsons deleted the feature/BI-895 branch July 26, 2021 18:20
timparsons added a commit that referenced this pull request Sep 29, 2021
[BI-895] - Convert the program user's table to use Buefy data tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants