Merge pull request #193 from Breeding-Insight/bug/BI-1372

[BI-1372] Add ontology sort option for entity + attribute
Breeding-Insight · Mar 8, 2022 · 0e79286 · 0e79286
2 parents c356ad3 + b07bb7a
commit 0e79286
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/src/breeding-insight/model/Sort.ts b/src/breeding-insight/model/Sort.ts
@@ -47,7 +47,7 @@ export enum OntologySortField {
   MethodDescription = 'methodDescription',
   ScaleClass = 'scaleClass',
   ScaleName = 'scaleName',
-  TraitDescription = 'traitDescription'
+  entityAttributeSortLabel = 'entityAttribute'
 }
 
 export class OntologySort {

diff --git a/src/components/ontology/OntologyTable.vue b/src/components/ontology/OntologyTable.vue
@@ -142,7 +142,7 @@
           v-bind:label="'Trait'"
           v-bind:visible="!traitSidePanelState.collapseColumns"
           v-bind:sortField="ontologySort.field"
-          v-bind:sortFieldLabel="traitDescriptionSortLabel"
+          v-bind:sortFieldLabel="entityAttributeSortLabel"
           v-bind:sortable="true"
           v-bind:sortOrder="ontologySort.order"
           v-on:newSortColumn="$emit('newSortColumn', $event)"
@@ -323,7 +323,7 @@ export default class OntologyTable extends Vue {
   private methodSortLabel: string = OntologySortField.MethodDescription;
   private scaleClassSortLabel: string = OntologySortField.ScaleClass;
   private unitSortLabel: string = OntologySortField.ScaleName;
-  private traitDescriptionSortLabel: string = OntologySortField.TraitDescription;
+  private entityAttributeSortLabel: string = OntologySortField.entityAttributeSortLabel;
 
   // New trait form
   private newTraitActive: boolean = false;

diff --git a/src/components/trait/TraitsImportTable.vue b/src/components/trait/TraitsImportTable.vue
@@ -54,7 +54,17 @@
             </AlertTriangleIcon>
           {{ data.observationVariableName }}
         </TableColumn>
-        <TableColumn name="trait" v-bind:label="'Trait'" v-bind:visible="!collapseColumns">
+        <TableColumn
+            name="trait"
+            v-bind:label="'Trait'"
+            v-bind:visible="!collapseColumns"
+            v-bind:sortField="importPreviewOntologySort.field"
+            v-bind:sortFieldLabel="entityAttributeSortLabel"
+            v-bind:sortable="true"
+            v-bind:sortOrder="importPreviewOntologySort.order"
+            v-on:newSortColumn="newSortColumn"
+            v-on:toggleSortOrder="toggleSortOrder"
+        >
           {{ data.entity | capitalize }} {{ data.attribute | capitalize }}
         </TableColumn>
         <TableColumn
@@ -203,6 +213,7 @@ export default class TraitsImportTable extends Vue {
   private methodSortLabel: string = OntologySortField.MethodDescription;
   private scaleClassSortLabel: string = OntologySortField.ScaleClass;
   private unitSortLabel: string = OntologySortField.ScaleName;
+  private entityAttributeSortLabel: string = OntologySortField.entityAttributeSortLabel;
 
   mounted() {
     this.updatePagination();