Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BI-2379 - Create Delete Endpoint for Deltabreed Sample Controller #440

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jan 9, 2025

Description

Story: BI-2379

  • Added endpoint in bi-api for deleting a sample submission
  • Currently only deletes sample submission record in bidb and samples in BrAPI server, need support for deleting plates in BrAPI server (see BI-2431)

Dependencies

  • latest brapi server

Testing

Change submission status in UI as needed to test different acceptance criteria as listed below:

GIVEN a DELETE programs/{programId}/submissions/{submissionId} request
WHEN the sample submission specified has a submission status of NOT SUBMITTED
THEN the sample submission is deleted (submission, samples, and plates)

GIVEN a DELETE programs/{programId}/submissions/{submissionId} request
WHEN the sample specified has a submission status of SUBMITTED or COMPLETED regardless of hard query parameter value
THEN the sample is not deleted and an error code of 409 is returned.

GIVEN a submission has been deleted
WHEN a new submission with the same name as a previously deleted submission is created
THEN it should be created without error (names can be reused)

The UI component of this work is not yet completed so api calls will need to be made manually. The request URL will look like:

DELETE http://localhost:8081/v1/programs/{programId}/submissions/{submissionId}

The programId and submissionId values can be grabbed from the browser path when navigated to the submission in question.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants